-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved schema preprocessor and Date
object handling (validation/serialization) for response bodies
#499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can cast data from request to object or transform object to string (or other type) in response. Documentation modified and an example project created
…ion. We must add an unique ID field in schema description in order to have a specific schema description for each component + Test added coercecomponents.spec.ts + example modified in order to expose a date
- Fix function names serialize and deserialize => To be clear for everybody on which functions are executed on requests and responses, it's now `deserializeRequestComponent` and `serializeResponseComponent`
@cdimascio I didn't validate the code itself, but I did validate this branch in my project and it works #1, without any modification required on my side. Fantastic work!! |
This is the magical line, isn't it?
:-) |
cdimascio
changed the title
update schema preprocessor
improved schema preprocessor and Dec 25, 2020
Date
object handling (validation/serialization) for response bodies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #493 for a detailed discussion on this topic
ObjectId
. it does pave the way for a custom serializer for MongoDbObjectId